Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/anat fast track derivative #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/anat fast track derivative #35

wants to merge 3 commits into from

Conversation

htwangtw
Copy link
Collaborator

@htwangtw htwangtw commented Apr 2, 2024 •
edited
Loading

Closes #32
Closes #33
Closes #34

Solution: ignore anatomical metrics if anat/ is not present

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 10.85%. Comparing base (c7b951f) to head (adf5437).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
- Coverage   94.46%   10.85%   -83.62%     
===========================================
  Files           5        8        +3     
  Lines         235      350      +115     
===========================================
- Hits          222       38      -184     
- Misses         13      312      +299
Files Coverage Δ
giga_auto_qc/workflow.py 8.10% <0.00%> (-77.61%) ⬇️
giga_auto_qc/tests/test_assessments.py 7.27% <0.00%> (ø)
giga_auto_qc/assessments.py 5.33% <0.00%> (-90.45%) ⬇️

... and 4 files with indirect coverage changes

@htwangtw
Copy link
Collaborator Author

@clarkenj On compute canada you can pull the build of this PR to test it out
apptainer build giga_auto_qc_unstable.simg docker://haotingwang/giga_auto_qc:unstable

@htwangtw
Copy link
Collaborator Author

htwangtw commented Apr 11, 2024 •
edited
Loading

Request from @clarkenj to be addressed: when supplying anatomical only directory, calculate the anatomical dice
Not addressing this as it turned out to be more complicated than I thought.

@htwangtw htwangtw mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpinsard bpinsard Awaiting requested review from bpinsard

@clarkenj clarkenj Awaiting requested review from clarkenj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@htwangtw @codecov-commenter